Skip to content

Commit

Permalink
fix(bakeManifest): add option for rawOverrides (#3225)
Browse files Browse the repository at this point in the history
adds an option to bake manifest for rawOverrides. this will be passed
onto rosco to enable the --set option in helm.
  • Loading branch information
ethanfrogers committed Oct 11, 2019
1 parent 4e1e03e commit 1b12c69
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ public class HelmBakeManifestRequest extends BakeManifestRequest {

private List<Artifact> values;

@JsonProperty("rawOverrides")
private Boolean rawOverrides;

public HelmBakeManifestRequest(
BakeManifestContext bakeManifestContext,
List<Artifact> inputArtifacts,
Expand All @@ -52,5 +55,6 @@ public HelmBakeManifestRequest(
this.setOverrides(overrides);
this.setNamespace(bakeManifestContext.getNamespace());
this.setInputArtifacts(inputArtifacts);
this.setRawOverrides(bakeManifestContext.getRawOverrides());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class BakeManifestContext {
private final String templateRenderer;
private final String outputName;
private final String namespace;

private final Boolean rawOverrides;
// There does not seem to be a way to auto-generate a constructor using our current version of
// Lombok (1.16.20) that
// Jackson can use to deserialize.
Expand All @@ -47,7 +47,8 @@ public BakeManifestContext(
@JsonProperty("outputName") String outputName,
@JsonProperty("namespace") String namespace,
@Nullable @JsonProperty("inputArtifact")
CreateBakeManifestTask.InputArtifactPair inputArtifact) {
CreateBakeManifestTask.InputArtifactPair inputArtifact,
@JsonProperty("rawOverrides") Boolean rawOverrides) {
this.inputArtifacts = inputArtifacts;
this.expectedArtifacts = expectedArtifacts;
this.overrides = overrides;
Expand All @@ -56,5 +57,6 @@ public BakeManifestContext(
this.outputName = outputName;
this.namespace = namespace;
this.inputArtifact = inputArtifact;
this.rawOverrides = rawOverrides;
}
}

0 comments on commit 1b12c69

Please sign in to comment.