fix(front50): Log an appropriate error if unable to fetch pipelines (#…

…2146)
spinnaker · Apr 12, 2018 · ae182f7 · ae182f7
1 parent 46d3b50
commit ae182f7
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/...-front50/src/main/groovy/com/netflix/spinnaker/orca/front50/tasks/MonitorFront50Task.java b/...-front50/src/main/groovy/com/netflix/spinnaker/orca/front50/tasks/MonitorFront50Task.java
@@ -23,6 +23,8 @@
 import com.netflix.spinnaker.orca.TaskResult;
 import com.netflix.spinnaker.orca.front50.Front50Service;
 import com.netflix.spinnaker.orca.pipeline.model.Stage;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
@@ -33,6 +35,7 @@
 
 @Component
 public class MonitorFront50Task implements RetryableTask {
+  private final Logger log = LoggerFactory.getLogger(getClass());
   private final Front50Service front50Service;
 
   @Autowired
@@ -73,6 +76,12 @@ public TaskResult execute(@Nonnull Stage stage) {
         Long lastModifiedTime = Long.valueOf(pipeline.get().get("updateTs").toString());
         return (lastModifiedTime > stage.getStartTime()) ? TaskResult.SUCCEEDED : TaskResult.RUNNING;
       } catch (Exception e) {
+        log.error(
+          "Unable to verify that pipeline has been updated (executionId: {}, pipeline: {})",
+          stage.getExecution().getId(),
+          stageData.pipelineName,
+          e
+        );
         return TaskResult.RUNNING;
       }
     }
@@ -85,5 +94,8 @@ private static class StageData {
 
     @JsonProperty("pipeline.id")
     public String pipelineId;
+
+    @JsonProperty("pipeline.name")
+    public String pipelineName;
   }
 }