fix(zombies): Set minimumActivity default method body, remove from de…

…fault parameter value (#4003)
spinnaker · Nov 18, 2020 · b20fc42 · b20fc42
1 parent f239424
commit b20fc42
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/admin/web/QueueAdminController.kt b/orca-queue/src/main/kotlin/com/netflix/spinnaker/orca/q/admin/web/QueueAdminController.kt
@@ -65,8 +65,8 @@ class QueueAdminController(
     )
 
   @PostMapping(value = ["/zombies:kill"])
-  fun killZombies(@QueryParam("minimumActivity") minimumActivity: Duration = Duration.ofMinutes(60)) {
-    getZombieExecutionService().killZombies(minimumActivity)
+  fun killZombies(@QueryParam("minimumActivity") minimumActivity: Long?) {
+    getZombieExecutionService().killZombies(Duration.ofMinutes(minimumActivity ?: 60))
   }
 
   @PostMapping(value = ["/zombies/{executionId}:kill"])
@@ -78,8 +78,8 @@ class QueueAdminController(
   @PostMapping(value = ["/zombies/application/{application}:kill"])
   @ResponseStatus(HttpStatus.NO_CONTENT)
   fun killApplicationZombies(@PathVariable application: String,
-                             @QueryParam("minimumActivity") minimumActivity: Duration = Duration.ofMinutes(60)) {
-    getZombieExecutionService().killZombies(application, minimumActivity)
+                             @QueryParam("minimumActivity") minimumActivity: Long?) {
+    getZombieExecutionService().killZombies(application, Duration.ofMinutes(minimumActivity ?: 60))
   }
 
   /**