Skip to content

Commit

Permalink
refactor(core): Clean up dependencies (#3599)
Browse files Browse the repository at this point in the history
An upcoming kork bump will remove some things that were api
dependencies and make them implementation; update places that
were relying on these to explicitly include them.
  • Loading branch information
ezimanyi committed Apr 14, 2020
1 parent 05a0820 commit e4f57eb
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions orca-core/orca-core.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ dependencies {
implementation("javax.servlet:javax.servlet-api:4.0.1")
implementation("com.jayway.jsonpath:json-path:2.2.0")
implementation("org.yaml:snakeyaml")
implementation("org.codehaus.groovy:groovy")

compileOnly("org.projectlombok:lombok")
annotationProcessor("org.projectlombok:lombok")
Expand Down
3 changes: 3 additions & 0 deletions orca-front50/orca-front50.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ apply from: "$rootDir/gradle/groovy.gradle"
dependencies {
implementation(project(":orca-core"))
implementation(project(":orca-retrofit"))

api("org.codehaus.groovy:groovy")

implementation("com.netflix.spinnaker.fiat:fiat-api:$fiatVersion")
implementation("com.netflix.spinnaker.fiat:fiat-core:$fiatVersion")
implementation("com.netflix.spectator:spectator-api")
Expand Down
1 change: 1 addition & 0 deletions orca-integrations-gremlin/orca-integrations-gremlin.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies {
implementation(project(":orca-kotlin"))
implementation(project(":orca-retrofit"))
implementation("org.springframework.boot:spring-boot-autoconfigure")
implementation("org.slf4j:slf4j-api")

testImplementation(project(":orca-core-tck"))
}
1 change: 1 addition & 0 deletions orca-retrofit/orca-retrofit.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ apply from: "$rootDir/gradle/groovy.gradle"
dependencies {
api("com.squareup.retrofit:retrofit")
api("com.squareup.retrofit:converter-jackson")
api("org.codehaus.groovy:groovy")

implementation(project(":orca-core"))
implementation("com.squareup.okhttp:okhttp")
Expand Down

0 comments on commit e4f57eb

Please sign in to comment.