feat(core): Change Execution & Stage IDs to use ULIDs #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you left out the IDs of tasks? |
|
@emjburns Good question. I only converted models that would have their own tables in SQL. For our initial implementation, tasks will just be serialized as part of the stage JSON blob, and won't have a table for themselves. |
|
Also Tasks are not currently assigned UUIDs. They're done like this
|
robfletcher
approved these changes
Apr 27, 2018
asher
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from
java.util.UUIDto ulid (via impl sulky-ulid) to get us a time-sortable ID in executions and stages. This is internals work for SQL.