fix(core): prevent app permissions from being lost during an app upse… #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
May 7, 2018
lwander
approved these changes
May 8, 2018
| @@ -44,10 +45,15 @@ class UpsertApplicationTask extends AbstractFront50Task { | |||
| } else { | |||
| log.info("Creating application (name: ${application.name})") | |||
| front50Service.create(application) | |||
| if (application?.permission?.permissions == null) { | |||
There was a problem hiding this comment.
You can probably groovify this with if (!application?.permission?.permissions)
There was a problem hiding this comment.
I want this condition to be true for an empty map - null should mean no change to the permissions, whereas [:] should mean an empty set of permissions.
There was a problem hiding this comment.
It'll also be true if application or permission are null when written like this -- is that intended?
There was a problem hiding this comment.
Yes for permission, no for application, so I'll take out the null check for application.
| } | ||
|
|
||
| try { | ||
| front50Service.updatePermission(application.name, application.permission) | ||
| if (application?.permission?.permissions != null) { |
danielpeach
force-pushed
the
fix-app-upsert
branch
2 times, most recently
from
548ba3d
to
bf987e9
Compare
danielpeach
force-pushed
the
fix-app-upsert
branch
from
bf987e9
to
51080b3
Compare
|
LGTM |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt operation