feat(provider/kubernetes): dynamic enable/disable #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Oct 19, 2018
lwander
force-pushed
the
enable-disable
branch
from
8fd698b
to
3a7efe9
Compare
jtk54
approved these changes
Oct 19, 2018
| StageData stageData = fromStage(stage); | ||
|
|
||
| if (StringUtils.isEmpty(stageData.criteria)) { | ||
| return new TaskResult(ExecutionStatus.SUCCEEDED); |
There was a problem hiding this comment.
What's the behavior of enable/disable with no targets?
There was a problem hiding this comment.
Noop -- this check here actually exists to allow you to either supply nothing, or explicitly reference a name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spinnaker/spinnaker#3470