fix(artifacts): Use client error return code for missing artifacts #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pipeline is missing artifacts on startup, we currently throw an IllegalStateException, which eventually returns a 500 code to the client. As this is a problem with the request, and it should not be retried, let's be more clear by making it an IllegalArgumentException, which returns a 400 code.
lwander
approved these changes
Nov 26, 2018
|
Pretty sure this addresses spinnaker/spinnaker#3201. Thanks much! |
|
@dbyron0 : Yes this (and spinnaker/echo#402) do indeed address that issue. I'll close the issue! |
dreynaud
pushed a commit
to dreynaud/orca
that referenced
this pull request
Dec 4, 2018
…pinnaker#2524) When a pipeline is missing artifacts on startup, we currently throw an IllegalStateException, which eventually returns a 500 code to the client. As this is a problem with the request, and it should not be retried, let's be more clear by making it an IllegalArgumentException, which returns a 400 code.
clanesf
pushed a commit
to clanesf/orca
that referenced
this pull request
Dec 8, 2018
…pinnaker#2524) When a pipeline is missing artifacts on startup, we currently throw an IllegalStateException, which eventually returns a 500 code to the client. As this is a problem with the request, and it should not be retried, let's be more clear by making it an IllegalArgumentException, which returns a 400 code.
jervi
added a commit
to jervi/orca
that referenced
this pull request
May 29, 2019
Same fix as spinnaker#2524, but for the case where multiple artifacts matches. Without this, Echo will try to trigger the pipeline five times and it will appear five times in the execution list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pipeline is missing artifacts on startup, we currently throw an IllegalStateException, which eventually returns a 500 code to the client. As this is a problem with the request, and it should not be retried, let's be more clear by making it an IllegalArgumentException, which returns a 400 code.