feat(cloudformation): add stack as output of CFN stage #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outputs of a CFN stack are available in the stack object, however we were not exposing them as the result of the CFN stage. This is usefull if one stack depends on the outputs of another stack, so we can chain them. This patch returns the stack object as a result of a successfull stage, so it's available in the context for later stages.
|
@ethanfrogers you may be interested? |
|
@spinnaker/reviewers PTAL |
robzienert
approved these changes
May 20, 2019
|
@spinnaker/reviewers is this ok to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outputs of a CFN stack are available in the stack object, however we
were not exposing them as the result of the CFN stage. This is usefull
if one stack depends on the outputs of another stack, so we can chain
them.
This patch returns the stack object as a result of a successfull stage,
so it's available in the context for later stages.