Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bake/rosco): fix regression in snake casing of rosco specific bake properties #2926

Merged
merged 1 commit into from
May 20, 2019
Merged

fix(bake/rosco): fix regression in snake casing of rosco specific bake properties #2926

merged 1 commit into from
May 20, 2019

Conversation

cfieber
Copy link
Contributor

@cfieber cfieber commented May 20, 2019

No description provided.

@cfieber cfieber requested a review from asher May 20, 2019 19:36
emjburns
emjburns reviewed May 20, 2019
View reviewed changes
orca-bakery/src/test/groovy/com/netflix/spinnaker/orca/bakery/api/BakeRequestSpec.groovy
output == '''\
{
"extended_attributes" : {
"aCamelAttribute" : "humps",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@cfieber cfieber merged commit dac2670 into spinnaker:master May 20, 2019
@cfieber cfieber deleted the snake_bake branch May 20, 2019 19:50
@cfieber
Copy link
Contributor Author

cfieber commented May 20, 2019

@spinnakerbot cherry-pick 1.14

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit dac2670) with exit code 1:

error: could not apply dac2670a2... fix(bake/rosco): fix regression in snake casing of rosco specific bake properties (#2926)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

cfieber added a commit to cfieber/orca that referenced this pull request May 20, 2019
@cfieber
fix(bake/rosco): fix regression in snake casing of rosco specific bak…
d81c99c 
…e properties (spinnaker#2926)
@cfieber cfieber mentioned this pull request May 20, 2019
Merged
cfieber added a commit that referenced this pull request May 20, 2019
@cfieber
fix(bake/rosco): fix regression in snake casing of rosco specific bak…
b98aa0d 
…e properties (#2926) (#2927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emjburns emjburns emjburns left review comments

@asher asher asher approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
4 participants
@cfieber @spinnakerbot @asher @emjburns