Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix bakery port in orca-web/config #2936

Merged
merged 2 commits into from
May 28, 2019

Conversation

zqfan
Copy link
Contributor

@zqfan zqfan commented May 24, 2019

rosco service listens port 8087, 8089 is listened by echo instead

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 3f3cd88: fix bakery port in orca-web/config

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

rosco service listens port 8087, 8089 is listened by echo instead
@zqfan zqfan changed the title fix bakery port in orca-web/config fix(config): fix bakery port in orca-web/config May 24, 2019
@ezimanyi
Copy link
Contributor

Thanks, that looks like it was a typo---though I think in essentially all cases this is going to be overridden by a custom orca.yml (whether halyard-generated or manually generated), which is likely why this hasn't caused any issues.

@ezimanyi ezimanyi merged commit 9b61964 into spinnaker:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants