fix(webhooks): addresses issue 3450 - introduce a delay before polling webhook #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchello2000
commented
Jun 12, 2019
| if (!missing.empty) { | ||
| throw new IllegalStateException("Missing required parameter${missing.size() > 1 ? 's' : ''} '${missing.join('\', \'')}'") | ||
| } | ||
| StageData stageData = stage.mapTo(StageData) |
There was a problem hiding this comment.
did some minor refactor here to bring into ~2018... :)
stageData and no more throws from here -> return TERMINAL instead
|
cc: @neelimamanubolu |
ezimanyi
reviewed
Jun 17, 2019
orca-webhook/src/main/groovy/com/netflix/spinnaker/orca/webhook/tasks/MonitorWebhookTask.groovy
Outdated
Show resolved
Hide resolved
orca-webhook/src/main/groovy/com/netflix/spinnaker/orca/webhook/tasks/MonitorWebhookTask.groovy
Show resolved
Hide resolved
...-webhook/src/test/groovy/com/netflix/spinnaker/orca/webhook/pipeline/WebhookStageSpec.groovy
Show resolved
Hide resolved
…g wehook Add additional parameters to the monitored webhook to allow: 1. waiting some number of seconds before polling starts 2. retrying on specific HTTP status codes Still needs deck counterpart see [3450](spinnaker/spinnaker#3450)
marchello2000
force-pushed
the
mark/spin-issue-3450
branch
from
4faf015
to
4b589c9
Compare
ezimanyi
approved these changes
Jun 21, 2019
marchello2000
added a commit
to marchello2000/deck
that referenced
this pull request
Jun 24, 2019
…g webhook Add additional parameters to the monitored webhook to allow: * waiting some number of seconds before polling starts * retrying on specific HTTP status codes see spinnaker#3450 orca counterpart (spinnaker/orca#2984)
marchello2000
added a commit
to spinnaker/deck
that referenced
this pull request
Jun 24, 2019
…g webhook (#7144) * fix(webhooks): addresses issue 3450 - introduce a delay before polling webhook Add additional parameters to the monitored webhook to allow: * waiting some number of seconds before polling starts * retrying on specific HTTP status codes see #3450 orca counterpart (spinnaker/orca#2984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional parameters to the monitored webhook to allow:
Still needs deck counterpart
see 3450