feat(perf): Favor a single pipeline config lookup #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching a single pipeline config _should_ be more efficient than fetching all pipelines (for an application) and filtering in `orca`. This is somewhat nuanced as the "all pipelines for application" is likely being served out of the in-memory cache. We have seen what looks like serialization-related load and this PR aims to offer some relief.
robzienert
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching a single pipeline config should be more efficient than
fetching all pipelines (for an application) and filtering in
orca.This is somewhat nuanced as the "all pipelines for application" is
likely being served out of the in-memory cache.
We have seen what looks like serialization-related load and this PR
aims to offer some relief.