Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(queue): After trying to start a queued execution that is CANCELED check the pipeline queue for additional waiting executions #3015

Conversation

christopherthielen
Copy link
Contributor

When:

  • you have a pipeline with isKeepWaitingPipelines: true
  • there are multiple NOT_STARTED queued up
  • you cancel one of the pipelines in the middle

then orca would stop doing work on that pipeline.

This change tells orca to check for additional waiting executions after ignoring a StartExecution for a cancelled execution.

…, check the pipeline queue for additional waiting executions
Copy link
Contributor

@asher asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherthielen christopherthielen merged commit 2a8492b into spinnaker:master Jun 26, 2019
@christopherthielen christopherthielen deleted the start-waiting-executions-when-starting-canceled-execution branch June 26, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants