feat(ecs): Add support for task definition artifacts #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Associated PRs: |
|
|
||
| private static class TaskDefinitionArtifact { | ||
| @Nullable public String artifactId | ||
| @Nullable public Artifact artifact |
There was a problem hiding this comment.
What if these are both null? What is the behavior if the task artifact resolver cant find an artifact?
There was a problem hiding this comment.
Looks like the resolver will continue try to map it into an object and potentially return a null object. I found that elsewhere a null check is done after calling it, I can add a similar check for this.
clareliguori
approved these changes
Jun 28, 2019
allisaurus
force-pushed
the
ecs-taskdef-artifact
branch
from
d887c7b
to
9293bd9
Compare
allisaurus
force-pushed
the
ecs-taskdef-artifact
branch
from
9293bd9
to
0a870df
Compare
clareliguori
reviewed
Jul 3, 2019
| if (description.fromContext) { | ||
| if (givenStage.execution.type == ExecutionType.ORCHESTRATION) { | ||
| // Use image from specific "find image from tags" stage | ||
| def imageStage = givenStage.findAncestor({ |
There was a problem hiding this comment.
Merge conflict fail: I think this is supposed to be "ancestorsWithParentPipelines.find" now based on the diff in line 52
There was a problem hiding this comment.
Hmm seems to be ok now? Not sure if something upstream changed to permit that.
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deploying an ECS Task Definition as an artifact.
This feature allows Task Definition attributes, including multiple containers, to be defined in an artifact (JSON file) and used in conjunction with pipeline images and other server group settings to deploy to ECS.