Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): deserialize nexus trigger #3130

Merged
merged 1 commit into from
Sep 13, 2019
Merged

fix(nexus): deserialize nexus trigger #3130

merged 1 commit into from
Sep 13, 2019

Conversation

claymccoy
Copy link
Contributor

No description provided.

@claymccoy
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.16

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #3149

@plumpy
Copy link
Member

plumpy commented Sep 13, 2019

Clay: Is this actually a bug fix? It appears to be a new feature, but we don't cherrypick new features into release branches. See the docs for cherrypicks here:
https://www.spinnaker.io/community/contributing/releasing/#merge-into-the-release-branch

If your patch fixes a bug, and doesn’t introduce a feature or breaking change, ...

Let me know if I'm wrong, but otherwise I'm going roll back these cherrypicks.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants