refactor(StageDefinitionBuilder): Delete deprecated aroundStages #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchello2000
force-pushed
the
mark/remove_aroundStages_master
branch
from
5e9a870
to
1c9c9ab
Compare
robzienert
approved these changes
Sep 13, 2019
| @Override | ||
| void afterStages(@Nonnull Stage stage, @Nonnull StageGraphBuilder graph) { | ||
| ArrayList<Stage> stages = new ArrayList<>() | ||
| HashMap<String, Object> nextStageContext = new HashMap<>() |
There was a problem hiding this comment.
Generally speaking, you shouldn't cast the variable with the implementation class, preferring the most common interface that you require. There are exceptions, but I don't believe this is one of them. There's a few spots that this is done in this PR that could be tidied a bit.
marchello2000
force-pushed
the
mark/remove_aroundStages_master
branch
2 times, most recently
from
8e26581
to
d17d046
Compare
Removing deprecated `aroundStages` (deprecated in early 2018) Also, removing `DeployStage`/`DeployStrategyStage` (marked deprecated in 2015) This logically simplifies the stage flow composition and gives us the opportunity for having smarter deploy strategies (which can plan things on failure, etc) - this is already added to the `Strategy` (e.g. `composeFlow` became `composeBeforeFlow`+`composeAfterFlow`) but it's not really taken advantage of [yet]
marchello2000
force-pushed
the
mark/remove_aroundStages_master
branch
from
d17d046
to
1322a1d
Compare
marchello2000
added a commit
to marchello2000/orca
that referenced
this pull request
Sep 20, 2019
The main issue being resolved here is how we determine if a source ASG is present during R/B deploy. In some cases, the `.asgName` property is used while others `.serverGroupName` is used. If we don't check both, some UI (tasks) operations don't work correctly, e.g. clone with red/black and leave max 2 remaining ASGs will fail to disable the old ASG as well skip the shrink step. While here, I am also making similar change to RRB and MD strategies. Additionally, cleaning up the `composeFlow` -> `composeBefore/AfterFlow` for strategies as a follow up from PR spinnaker#3133
marchello2000
added a commit
that referenced
this pull request
Sep 20, 2019
The main issue being resolved here is how we determine if a source ASG is present during R/B deploy. In some cases, the `.asgName` property is used while others `.serverGroupName` is used. If we don't check both, some UI (tasks) operations don't work correctly, e.g. clone with red/black and leave max 2 remaining ASGs will fail to disable the old ASG as well skip the shrink step. While here, I am also making similar change to RRB and MD strategies. Additionally, cleaning up the `composeFlow` -> `composeBefore/AfterFlow` for strategies as a follow up from PR #3133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecated
aroundStages(deprecated in early 2018)Also, removing
DeployStage/DeployStrategyStage(marked deprecated in 2015)This logically simplifies the stage flow composition and gives us the opportunity for
having smarter deploy strategies (which can plan things on failure, etc) - this is already
added to the
Strategy(e.g.composeFlowbecamecomposeBeforeFlow+composeAfterFlow)but it's not really taken advantage of [yet]