refactor(google): convert GceDeployStagePreProcessor to Java #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimanyi
approved these changes
Sep 16, 2019
...om/netflix/spinnaker/orca/clouddriver/pipeline/providers/gce/GceDeployStagePreProcessor.java
Show resolved
Hide resolved
...om/netflix/spinnaker/orca/clouddriver/pipeline/providers/gce/GceDeployStagePreProcessor.java
Outdated
Show resolved
Hide resolved
maggieneterval
force-pushed
the
gce-deploy-java
branch
from
e454a75
to
618af9f
Compare
maggieneterval
changed the title
plumpy
approved these changes
Sep 16, 2019
...etflix/spinnaker/orca/clouddriver/pipeline/providers/gce/GceDeployStagePreProcessorTest.java
Outdated
Show resolved
Hide resolved
...etflix/spinnaker/orca/clouddriver/pipeline/providers/gce/GceDeployStagePreProcessorTest.java
Outdated
Show resolved
Hide resolved
...om/netflix/spinnaker/orca/clouddriver/pipeline/providers/gce/GceDeployStagePreProcessor.java
Outdated
Show resolved
Hide resolved
maggieneterval
force-pushed
the
gce-deploy-java
branch
from
a47c8d9
to
845280a
Compare
maggieneterval
added a commit
to maggieneterval/orca
that referenced
this pull request
Sep 24, 2019
…er#3157) * chore(google): add tests for GceDeployStagePreProcessor * refactor(google): convert GceDeployStagePreProcessor to Java * fix(google): change return types from List to ImmutableList * fix(google): improve readability based on the wisdom of plumpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(google): add tests for GceDeployStagePreProcessor
Adds tests that demonstrate that in a GCE red/black deployment, the
GceDeployStagePreProcessoradds aResizeServerGroupStage, which "pins" the source server group's minimum capacity as its desired capacity, before aCaptureSourceServerGroupCapacityTask, which snapshots the source server group's minimum capacity (to later be re-applied to the target server group).refactor(google): convert GceDeployStagePreProcessor to Java
For clarity, removes references to rolling red/black, because as far as I know we have no plans to implement this strategy in GCE.