Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run CancellableStage cancel method on dedicated thread pool #3164

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

asher
Copy link
Contributor

@asher asher commented Sep 17, 2019

When fillExecutorEachCycle is enabled, keiko attempts to completely fill the messageHandlerPool executor which is configured to rejects executions when full instead of queue. CancelStageHandler attempted to fire and forget cancel methods by running on the same executor despite the fact that keiko attempts to keep it full. Running cancel methods on a dedicated threadpool resolves this race condition while preserving the fire-and-forget semantics that allow cancel methods to run beyond keiko's ackTimeout.

@asher asher merged commit efe1163 into spinnaker:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants