fix(core): run CancellableStage cancel method on dedicated thread pool #3164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
fillExecutorEachCycle
is enabled, keiko attempts to completely fill themessageHandlerPool
executor which is configured to rejects executions when full instead of queue.CancelStageHandler
attempted to fire and forget cancel methods by running on the same executor despite the fact that keiko attempts to keep it full. Running cancel methods on a dedicated threadpool resolves this race condition while preserving the fire-and-forget semantics that allow cancel methods to run beyond keiko'sackTimeout
.