fix(monitored deploy): add monitored deploy to same checks as RRB #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marchello2000
commented
Sep 24, 2019
marchello2000
commented
- add monitored deploy to checks where we check for RRB (since, semantically, they are same)
- make some better summary messages
marchello2000
commented
Sep 24, 2019
| // TODO(dreynaud): enabling cautiously for RRB/MD only for testing, but we would ideally roll this out to other strategies | ||
| Strategy strategy = Strategy.fromStrategyKey(stageData.strategy) | ||
|
|
||
| return (((strategy == Strategy.ROLLING_RED_BLACK) || (strategy == Strategy.MONITORED)) |
There was a problem hiding this comment.
@dreynaud i know you prefer in [] i think this i like this better since it's closer to java for when we convert it all... maybe... someday
There was a problem hiding this comment.
supportedStrategies.contains(strategy)? :)
* add monitored deploy to checks where we check for RRB (since, semantically, they are same) * make some better summary messages
marchello2000
force-pushed
the
mark/monitored_fixes3
branch
from
859b967
to
0e31769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.