fix(tasks): limit task maxBackoff time to 2min #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the limitation went in because we needed to be sure we refreshed the TTL on the lock - I'm not sure we need to constrain it any further. That said, it is probably better to revisit the task with some frequency - I suspect it might give us a better story around killing off things that have been cancelled etc |
cfieber
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxTaskBackoffforRetryableTaskRunTaskmessages was previously limited viaLockExtendingTaskExecutionInterceptorwhich was removed by chore(core): removing clusterLock feature #3136. This makes the prior backoff constraint the default as it assists with patching and cancellation of in-flight executions.