fix(cfn): Return RUNNING if an error occurred #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force cache refreshing was a retryable task. However, it didn't return RUNNING whenever the cache refresh failed, and thus the task failed immediately. This patch makes the task return RUNNING whenever there's an exception refreshing the cache so it actually retries.
marchello2000
approved these changes
Oct 3, 2019
|
Yes, sorry as well, I missed this too :-) |
|
@spinnakerbot cherry-pick 1.16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Oct 4, 2019
* fix(cfn): Return RUNNING if an error occurred Force cache refreshing was a retryable task. However, it didn't return RUNNING whenever the cache refresh failed, and thus the task failed immediately. This patch makes the task return RUNNING whenever there's an exception refreshing the cache so it actually retries.
|
Cherry pick successful: #3216 |
marchello2000
pushed a commit
that referenced
this pull request
Oct 7, 2019
* fix(cfn): Return RUNNING if an error occurred Force cache refreshing was a retryable task. However, it didn't return RUNNING whenever the cache refresh failed, and thus the task failed immediately. This patch makes the task return RUNNING whenever there's an exception refreshing the cache so it actually retries.
|
@spinnaker please reopen |
|
@spinnakerbot I have similar issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force cache refreshing was a retryable task. However, it didn't return
RUNNING whenever the cache refresh failed, and thus the task failed
immediately. This patch makes the task return RUNNING whenever there's
an exception refreshing the cache so it actually retries.