fix(cfn): include credentials on the task sent to clouddriver (#3323) #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clouddriver expects the credentials to be on the kato task context we sent from Orca. That was not the case for the DeleteCloudFormationTask so it was failing in Clouddriver. This patch adds the credentials field so clouddriver can do the task conversion properly.
spinnaker-release
deleted the
auto-cherry-pick-1.17-121d743559164cc51fdfe37c27be51a23002afd4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clouddriver expects the credentials to be on the kato task context we
sent from Orca. That was not the case for the DeleteCloudFormationTask
so it was failing in Clouddriver.
This patch adds the credentials field so clouddriver can do the
task conversion properly.