feat(pipeline executions/orca): Add configurable default for skipDown… #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robzienert @ajordens @marchello2000 @robfletcher can you please take a look? |
dreynaud
requested changes
Jul 20, 2021
orca-front50/src/main/java/com/netflix/spinnaker/orca/front50/pipeline/PipelineStage.java
Outdated
Show resolved
Hide resolved
…streamOutput flag
dreynaud
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to set a default value for the
skipDownstreamOutputintroduced in this PR.This way we can control the behaviour globally and decide which one is the exception.
In our case none of the child pipelines uses the output of a previous one.
Issue: spinnaker/spinnaker#6159