Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): Yaml parse bug in liquibase changelog file #4639

Merged
merged 3 commits into from Feb 1, 2024

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Feb 1, 2024

A bug was introduced here: https://github.com/spinnaker/orca/pull/4620/files#diff-ee59a85cbdc61d39167704f4b52d85914400ef9e6ae4ad843f56a796877ae271R56. It causes an Orka crash on startup.

org.yaml.snakeyaml.scanner.ScannerException: mapping values are not allowed here
  in 'reader', line 57, column 9:
         file: changelog/20201214-create-comp ...
             ^
     at org.yaml.snakeyaml.scanner.ScannerImpl.fetchValue(ScannerImpl.java:869)
     at org.yaml.snakeyaml.scanner.ScannerImpl.fetchMoreTokens(ScannerImpl.java:358)
     at org.yaml.snakeyaml.scanner.ScannerImpl.checkToken(ScannerImpl.java:227)
     at org.yaml.snakeyaml.parser.ParserImpl$ParseIndentlessSequenceEntry.produce(ParserImpl.java:530)
     at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:158)
     at org.yaml.snakeyaml.parser.ParserImpl.checkEvent(ParserImpl.java:148)
     at org.yaml.snakeyaml.composer.Composer.composeSequenceNode(Composer.java:208)
     at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:160)
     at org.yaml.snakeyaml.composer.Composer.composeValueNode(Composer.java:257)
     at org.yaml.snakeyaml.composer.Composer.composeMappingChildren(Composer.java:248)
     at org.yaml.snakeyaml.composer.Composer.composeMappingNode(Composer.java:236)
     at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:162)
     at org.yaml.snakeyaml.composer.Composer.getNode(Composer.java:95)
     at org.yaml.snakeyaml.composer.Composer.getSingleNode(Composer.java:119)
     at org.yaml.snakeyaml.constructor.BaseConstructor.getSingleData(BaseConstructor.java:150)
     at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:490)
     at org.yaml.snakeyaml.Yaml.load(Yaml.java:429)
     at liquibase.parser.core.yaml.YamlChangeLogParser.parseYamlStream(YamlChangeLogParser.java:101)

@dbyron-sf
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Feb 1, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/docs_master.yml without workflows permission

Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this didn't break in the PR build. Thanks for catching it!

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Feb 1, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 1, 2024
@mergify mergify bot merged commit 8c563f5 into spinnaker:master Feb 1, 2024
4 checks passed
@jervi jervi deleted the patch-1 branch February 9, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.34
Projects
None yet
3 participants