Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): Correctly pass Version to Docker builds and remove Release Phase var #328

Merged
merged 3 commits into from
Mar 18, 2022
Merged

refactor(ci): Correctly pass Version to Docker builds and remove Release Phase var #328

merged 3 commits into from
Mar 18, 2022

Commits on Mar 13, 2022

  1. refactor(docker): Consolidate on single Dockerfile 

    Also correctly pass Version & Release Phase values via ldflags to `go
build` so `spin --version` outputs correct values.
    @kskewes-sf
    kskewes-sf committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    ebb26cd View commit details
    Browse the repository at this point in the history

  2. chore(ci): Remove redundant build.sh file 

    Only `./Dockerfile` was calling `build.sh` and it doesn't in previous
commit.

Future CI jobs can run `go build` directly supplying OS & ARCH matrix and
LDFLAGS.

For local development we can simply run `go build`.
    @kskewes-sf
    kskewes-sf committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    ff014d5 View commit details
    Browse the repository at this point in the history

  3. refactor(build): Remove Release Phase and only use Version 

    `Version` is SemVer so we can add release candidate and other
designations as required.

Continue to use `dev` as default version, overridable by building with
ldflag set.
    @kskewes-sf
    kskewes-sf committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    54d4123 View commit details
    Browse the repository at this point in the history