fix(encoding): Fix double-encoding of HTTP response #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecba3ea added a call to encode the response body before sending it to the server if the body is of type str. This is the correct behavior for python 3, where str represents a an unencoded string, but is incorrect for python 2. In python 2, str represents an already-encoded string and unicode represents an unencoded string. This is breaking for prometheus monitoring, which is sending already- encoded bytes to the respond() function. In python 2, those have type str, so we're trying to re-encode them. This works fine as long as there are only ASCII characters in the string, but breaks otherwise. In order to support both python 2 and 3, try to use 'unicode' (as exists in 2) and if it's absent assign str to unicode.
|
I was able to successfully get the |
plumpy
approved these changes
Oct 7, 2019
|
@spinnakerbot 🍒 ⛏️ 1.16 |
|
@spinnakerbot 🍒 ⛏️ 1.16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Oct 7, 2019
ecba3ea added a call to encode the response body before sending it to the server if the body is of type str. This is the correct behavior for python 3, where str represents a an unencoded string, but is incorrect for python 2. In python 2, str represents an already-encoded string and unicode represents an unencoded string. This is breaking for prometheus monitoring, which is sending already- encoded bytes to the respond() function. In python 2, those have type str, so we're trying to re-encode them. This works fine as long as there are only ASCII characters in the string, but breaks otherwise. In order to support both python 2 and 3, try to use 'unicode' (as exists in 2) and if it's absent assign str to unicode.
|
Cherry pick successful: #221 |
louisjimenez
pushed a commit
that referenced
this pull request
Oct 7, 2019
ecba3ea added a call to encode the response body before sending it to the server if the body is of type str. This is the correct behavior for python 3, where str represents a an unencoded string, but is incorrect for python 2. In python 2, str represents an already-encoded string and unicode represents an unencoded string. This is breaking for prometheus monitoring, which is sending already- encoded bytes to the respond() function. In python 2, those have type str, so we're trying to re-encode them. This works fine as long as there are only ASCII characters in the string, but breaks otherwise. In order to support both python 2 and 3, try to use 'unicode' (as exists in 2) and if it's absent assign str to unicode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#4980
ecba3ea added a call to encode the response body before sending it to the server if the body is of type str.
This is the correct behavior for python 3, where str represents a an unencoded string, but is incorrect for python 2. In python 2, str represents an already-encoded string and unicode represents an unencoded string.
This is breaking for prometheus monitoring, which is sending already-encoded bytes to the respond() function. In python 2, those have type str, so we're trying to re-encode them. This works fine as long as there are only ASCII characters in the string, but breaks otherwise.
In order to support both python 2 and 3, try to use 'unicode' (as exists in 2) and if it's absent assign str to unicode.