feat(ecs): Add artifact support, operation mappings to reference page #1452
Conversation
|
CC: @clareliguori |
allisaurus
force-pushed
the
ecs-artifact-update
branch
from
411994b
to
75dbda0
Compare
reference/providers/ecs.md
Outdated
| @@ -7,13 +7,41 @@ sidebar: | |||
|
|
|||
| {% include toc %} | |||
|
|
|||
| ## Resource Mapping | |||
| ## Resource mapping | |||
|
|
|||
| ### Server Group | |||
There was a problem hiding this comment.
Probably someone like @dorbin can help us with correct casing here. This change has "Resource mapping" and "Operation mapping", but "Server Group" (capital G)
There was a problem hiding this comment.
Sadly, we've got inconsistent capitalization of "server group" on the site. I don't see it as a proper noun, and we're trying to keep our headings to sentence case. So I think it should be "Server group"
There was a problem hiding this comment.
In several other reference pages, section headers (e.g., "Resource mapping") are cased as above. "Server Group" is more inconsistent across these same pages, however is either always or mostly capitalized on both words.
I'll change "Server Group" to always be upper case, but defer to guidance from @dorbin or others.
reference/providers/ecs.md
Outdated
| There are two ways to specify server group settings for ECS: | ||
|
|
||
| * __Inputs (default)__: | ||
| Specify the container image, resource limits, and other settings needed to create an [ECS task definition](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definitions.html) and [service](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs_services.html#service_concepts) directly in the server group. This option supports deploying one container per Amazon ECS task (equivalent to a Spinnaker "instance"). |
There was a problem hiding this comment.
Double check on ECS -> Amazon ECS everywhere, to match our naming in the official AWS docs
reference/providers/ecs.md
Outdated
| ## Operation mapping | ||
|
|
||
| ### Deploy | ||
| Deploys a new Amazon ECS Service to the specified server group(s). For load balanced services, the previous service will be drained after the new service is considered healthy. |
There was a problem hiding this comment.
Should service be upper case or lower case?
There was a problem hiding this comment.
for consistency, ECS resource types seem to be always lower case; will change.
reference/providers/ecs.md
Outdated
| Scales the desired count for the ECS service down to 0, then deletes the service. | ||
|
|
||
| ### Disable | ||
| Scales the desired count for the ECS service down to 0, so no instances are running. |
There was a problem hiding this comment.
Should we continue doing "instances (tasks)" here and below in Resize?
|
@dorbin Now that 1.15 is out, any feedback before getting this merged? |
|
Sorry, Clare, et al, I was out at a summit all last week. |
Artifact support added in 1.15.0:
spinnaker/clouddriver#3825