This repository has been archived by the owner on Jul 10, 2021. It is now read-only.
Update index.md #1967
Open
Update index.md #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion to simplify a sentence to make it shorter. Another suggestion I have is to add additional content to the sentence "It's a good idea though to communicate to the team what templates are available." but I don't exactly know the real reason why it is good. Is it because it will save time for others having to recreate something that may already exist? Sharing why it's good may encourage people to communicate more.
317brian
reviewed
Jul 23, 2020
| @@ -34,9 +34,9 @@ on an existing pipeline. | |||
|
|
|||
| * Share the template with one or more teams of developers using Spinnaker. | |||
|
|
|||
| To [save a pipeline | |||
| [Saving a pipeline | |||
There was a problem hiding this comment.
The rest of the list starts w/ a verb, such as use. Can you rewrite the sentence to be start w/ "Save" so that it's consistent with the others?
There was a problem hiding this comment.
Hi Brian,
The rest of the list does start with a verb, but I thought this sentence in particular is more of a note to provide additional context to the second bullet. If this sentence should be an action / step, then I think this should appear as the bullet instead.
Ex.
- Save a pipeline template to Spinnaker.
This will make the template available to developers. It's a good idea to communicate to the team about what templates are available.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to simplify a sentence to make it shorter.
Another suggestion I have is to add additional content to the sentence "It's a good idea though to communicate to the team what templates are available." but I don't exactly know the real reason why it is good.
Is it because it will save time for others having to recreate something that may already exist? Sharing why it's good may encourage people to communicate more.