fix(core): Fixing optout flow #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeyrschabu
commented
Nov 6, 2019
jeyrschabu
commented
- moved cloud provider opt out actions to handler
- update handler interface optout function
- fix abstraction for optout flow
|
@aravindmd per our discussion this PR fixes issues we are seeing with the optout flow. |
- moved cloud provider opt out actions to handler - update handler interface optout function - fix abstraction for optout flow
jeyrschabu
force-pushed
the
tagging-proper
branch
from
17a0681
to
d782735
Compare
aravindmd
reviewed
Nov 6, 2019
| currentStatus = status, | ||
| statuses = setOf(optOutState.statuses + status).flatten().toMutableList() | ||
| ).apply { | ||
| resourceStateRepository.upsert(this) |
There was a problem hiding this comment.
what about resourceRepository.upsert() ? will this take care of resource upsert ?
There was a problem hiding this comment.
Why would we do that while we are ensuring this resource is opted out & umarked?
There was a problem hiding this comment.
ok so we don't need to update the resource state , i ask this because the previous optout flow had this call?
There was a problem hiding this comment.
That was definitely a bug. resourceRepository.upsert would end up marking the resource. ResourceStateRepository.upsert does update the status to opted out which is what we need
aravindmd
approved these changes
Nov 6, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.