Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Part of Speech tags counting #15

Closed
wants to merge 7 commits into from

Conversation

fdartayre
Copy link

@fdartayre fdartayre commented Sep 25, 2017

Hi Alexander. Please have a look on the following pull request.

It contains:

  • A new processor that uses OpenNLP POS tagger to count the different part of speech tags (the named entity recognition processor was renamed to avoid confusion between the two processors of the plugin)
  • Upgrade to Elasticsearch 5.6.1
  • Compatibility with Gradle 4.x
  • Updated tests and README.md

@yehosef
Copy link

yehosef commented Dec 26, 2017

+1 - this would be great!

@spinscale
Copy link
Owner

I upgraded to ES 6.0 in the meantime... any chance for a rebase?

@fdartayre
Copy link
Author

I will have a look on upgrading to ES 6.x as soon as possible

@ninesalt
Copy link

If this is still wanted, I added POS support in my fork for v6.5.4. I probably could have saved a lot of time by checking this PR and modified @fdartayre's fork before I forked the repo and added support for POS myself. Apart from the difference in versions, my fork counts the occurence of specific words as well. For example:


      "NNS": {
          "times": 1,
          "players": 3,
          "points": 1
      }, 

@spinscale
Copy link
Owner

@ninesalt feel free to open a PR!

@spinscale
Copy link
Owner

unfortunately this cannot be merged anymore. I do not have time to work on this. I will close this for now and hope someone opens a new PR.

@spinscale spinscale closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants