Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ignored_users support #11

Merged
merged 3 commits into from
Feb 7, 2014
Merged

added ignored_users support #11

merged 3 commits into from
Feb 7, 2014

Conversation

moul
Copy link
Contributor

@moul moul commented Feb 7, 2014

No description provided.

@spion
Copy link
Owner

spion commented Feb 7, 2014

Its a bit of a nitpick, but I suggest ignore instead of ignored_users. Its a fairly standard term among IRC users I think ("ignore" lists and such) plus it doesn't break the general javascript camelCase convention.

Other than that, this is great - I've been wanting to do this for a while but kept postponing it. Thanks!

@moul
Copy link
Contributor Author

moul commented Feb 7, 2014

I first used ignore instead of ignored_users, but I though about another future need: ignored_words :)

For the camel case style, I used to keep it in javascript code, but preferred not to use it in the config file, be free to change it :)

@spion
Copy link
Owner

spion commented Feb 7, 2014

Hrm. There is also the option to nest :P

ignore:
    users:
        - regex1
        - regex2
    words:
        - word1
        - word2

@moul
Copy link
Contributor Author

moul commented Feb 7, 2014

fixed !

@spion
Copy link
Owner

spion commented Feb 7, 2014

Allright! :P

spion added a commit that referenced this pull request Feb 7, 2014
added ignored_users support
@spion spion merged commit fb8e6bb into spion:master Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants