Requires the Exception to be instance of HttpExceptionInterface to ch…

…eck for getResponse() method
spira · Jun 26, 2015 · 0095401 · 0095401
1 parent dd31da5
commit 0095401
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/api/app/Exceptions/ValidationException.php b/api/app/Exceptions/ValidationException.php
@@ -2,8 +2,9 @@
 
 use Illuminate\Support\MessageBag;
 use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 
-class ValidationException extends HttpException
+class ValidationException extends HttpException implements HttpExceptionInterface
 {
 
     /**

diff --git a/api/app/Http/Controllers/BaseController.php b/api/app/Http/Controllers/BaseController.php
@@ -207,14 +207,14 @@ public static function renderException($request, \Exception $e, $debug = false){
             'message' => $message,
         ];
 
-        if (method_exists($e, 'getResponse')) {
-            $response = $e->getResponse();
-        }
-
         $statusCode = 500;
 
         if ($e instanceof HttpExceptionInterface){
             $statusCode = $e->getStatusCode();
+
+            if (method_exists($e, 'getResponse')) {
+                $response = $e->getResponse();
+            }
         }
 
         if ($debug){