Added test for saving user without any changes

spira · Sep 21, 2015 · 6f22cd6 · 6f22cd6
1 parent a2ac10e
commit 6f22cd6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/app/src/common/services/user/userService.spec.ts b/app/src/common/services/user/userService.spec.ts
@@ -283,6 +283,19 @@ namespace common.services.user {
                 $httpBackend.flush();
             });
 
+
+
+            it('should not make an api call if nothing has changed', () => {
+
+                let user = common.models.UserMock.entity();
+                user.setExists(true);
+
+                let savePromise = userService.saveUserWithRelated(user);
+
+                expect(savePromise).eventually.to.equal(user);
+
+            });
+
         });
 
     });

diff --git a/app/src/common/services/user/userService.ts b/app/src/common/services/user/userService.ts
@@ -197,6 +197,10 @@ namespace common.services.user {
          */
         private saveUserProfile(user:common.models.User):ng.IPromise<common.models.UserProfile|boolean>{
 
+            if (!user._userProfile){ //don't try to save if there is no profile
+                return this.$q.when(false);
+            }
+
             let changes:any = (<common.decorators.IChangeAwareDecorator>user._userProfile).getChanged();
             if (_.isEmpty(changes)){
                 return this.$q.when(false);