Dropped redundant HttpExceptionInterface call, fixed testCreateOrRepl…

…aceUpdate test
spira · Jun 26, 2015 · c14a731 · c14a731
1 parent 486d70d
commit c14a731
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/api/app/Exceptions/ValidationException.php b/api/app/Exceptions/ValidationException.php
@@ -2,9 +2,8 @@
 
 use Illuminate\Support\MessageBag;
 use Symfony\Component\HttpKernel\Exception\HttpException;
-use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 
-class ValidationException extends HttpException implements HttpExceptionInterface
+class ValidationException extends HttpException
 {
 
     /**

diff --git a/api/app/Http/Controllers/BaseController.php b/api/app/Http/Controllers/BaseController.php
@@ -3,7 +3,6 @@
 use App;
 use Laravel\Lumen\Routing\Controller;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Illuminate\Http\Request;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Collection;

diff --git a/api/tests/Repositories/TestRepositoryTest.php b/api/tests/Repositories/TestRepositoryTest.php
@@ -89,7 +89,9 @@ public function testCreateOrReplaceUpdate()
         $entity = factory(App\Models\TestEntity::class)->create();
         $id = $entity->entity_id;
 
-        $entityUpdate = factory(App\Models\TestEntity::class)->make();
+        $entityUpdate = factory(App\Models\TestEntity::class)->make([
+            'entity_id' => $id //make sure the id doesn't change
+        ]);
         $entityUpdate = $entityUpdate->getAttributes();
 
         $rowCount = $this->repository->count();