Fix/remove image linking #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Replaced primary image with actual foreign key to images table
… use the same image every time.
…-linking * 'master' of github.com:spira/spira: Dropped unit test only flag Added test for video embed directive Applied fixes from StyleCI Added tests for content sections input item, fixed all tests for section media due to the new inherited controller pattern Fixed preview mode for sections, added caption to video form Added tooltips to section buttons, added sort feature for media section type Added styling to the select media image dialog, changed so two buttons target the dialog Added polish to the video and image section type Fixed video embed display to have flexible 16:9 ratio, implemented iframe toggling to ensure reload of frame Added video embed directive Tidied styling of video embed section type Fixed vagrant port renumbering Applied fixes for the sectionable model to always add type for validation, various style fixes to content sections Retructured content sections to have an intermediary directive to allow for per-section control of generic settings Started work on abstracting section input settings to bottomsheet, need to create intermediary sectionInput directive to be able to handle bottom sheets on a per-input basis, not global Rename section image to section media, added video capabilities. Still need to add tests for switcher, and tidy the ui for videos. Fixed frontend check for roles attribute, and fixed use seeder to use sync method as saveMany and save do not apply to the database In api, renamed ImageContent to MediaContent and extended the media content mocks to generate video mocks for media section
Applied fixes from StyleCI
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.