Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rate limiting with Flask-Limiter #1054

Closed
Glandos opened this issue Aug 9, 2022 · 1 comment
Closed

Implement rate limiting with Flask-Limiter #1054

Glandos opened this issue Aug 9, 2022 · 1 comment
Assignees

Comments

@Glandos
Copy link
Member

Glandos commented Aug 9, 2022

We currently have a number of issue with rate limiting, in login, admin or invite forms.

@0livd implemented a custom made LoginThrottler in #249 that served well, but is limited. I open this discussion to the usage of https://flask-limiter.readthedocs.io/en/stable/index.html This has the main drawbacks of adding more dependencies to the project, but can effectively increase the security for every user.

@0livd do you have an opinion on this new dependency, since your code will be obsolete in the case we use Flask-Limiter? And for everyone, do you have experience with this? Otherwise, I am willing to perform some tests with this.

@almet
Copy link
Member

almet commented Aug 9, 2022

Hey, thanks for opening this. Using Flask-Limiter seems a good way to move forward on this. It's easy enough and seems maintained. It's okay to have one more dependency for stuff like this in my opinion.

Cheers.

@Glandos Glandos self-assigned this Aug 28, 2022
Glandos added a commit to Glandos/ihatemoney that referenced this issue Aug 28, 2022
@almet almet closed this as completed in e7ab3c1 Dec 10, 2022
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants