Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joining a room using URL makes other rooms menu polluted #1081

Closed
ghost opened this issue Oct 22, 2022 · 1 comment
Closed

Joining a room using URL makes other rooms menu polluted #1081

ghost opened this issue Oct 22, 2022 · 1 comment
Assignees
@Glandos

Comments

@ghost
Copy link

ghost commented Oct 22, 2022 •
edited by ghost
Loading

Reproduction steps - use private browsing to start with a clean setup:

  1. Go to ihatemoney.org demo instance
  2. Open drop-down menu - there are no other rooms listed
    Screenshot from 2022-10-22 18-25-56
  3. Go to https://ihatemoney.org/raisingsomebugs123456/join/WyJyYWlzaW5nc29tZWJ1Z3MxMjM0NTYiXQ.bdc5s4d6rqx9qLjem3tKrGi-UyA twice in a new tab
  4. Switch back to the tab with demo instance and refresh
  5. Open drop-down menu - test room is listed twice
    Screenshot from 2022-10-22 18-26-56

Expected:
Test room is listed once
@Glandos Glandos self-assigned this Oct 22, 2022
Glandos added a commit to Glandos/ihatemoney that referenced this issue Oct 22, 2022
@Glandos
use a dict for project list
b5c948e 
this avoid finding duplicates, and we only need id -> name

also, use a common function to avoid duplicate code

fix spiral-project#1081
@Glandos Glandos mentioned this issue Oct 22, 2022
Merged
Glandos added a commit that referenced this issue Oct 22, 2022
@Glandos
use a dict for project list
dc40c8f 
this avoid finding duplicates, and we only need id -> name

also, use a common function to avoid duplicate code

fix #1081
@Glandos
Copy link
Member

Glandos commented Oct 22, 2022

With a perfect bug report comes a quick fix. Thanks a lot!

@Glandos Glandos closed this as completed Oct 22, 2022
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this issue Mar 2, 2024
@Glandos
use a dict for project list
8b5daf2 
this avoid finding duplicates, and we only need id -> name

also, use a common function to avoid duplicate code

fix spiral-project#1081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glandos Glandos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Glandos