Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a full JavaScript client #149

Closed
JocelynDelalande opened this issue Sep 4, 2016 · 19 comments
Closed

Make a full JavaScript client #149

JocelynDelalande opened this issue Sep 4, 2016 · 19 comments

Comments

@JocelynDelalande
Copy link
Contributor

Hi,

@almet just to know what you would think about switching to a single-page-app framework like AngularJS, ReactJS… Goal is to get better experience for the user (#113 will help that also). The REST API would allow us to switch to this approach quite easily.

I'm not asking anyone to do it. I just would like to know, if I PR that kind of big change, would it be welcome or not ?

@almet ?

@almet
Copy link
Member

almet commented Sep 4, 2016

Il will, yes!

I am thinking that using kinto.js would be interesting

Le 4 septembre 2016 20:54:46 GMT+02:00, JocelynDelalande notifications@github.com a écrit :

Hi,

@almet just to know what you would think about switching to a
single-page-app framework like AngularJS, ReactJS… Goal is to get
better experience for the user (#113 will help that also). The REST API
would allow us to switch to this approach quite easily.

I'm not asking anyone to do it. I just would like to know, if I PR that
kind of big change, would it be welcome or not ?

@almet ?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#149

@almet
Copy link
Member

almet commented Sep 12, 2016

Do you plan to work on this or were you asking just out of curiosity? :-)

@JocelynDelalande
Copy link
Contributor Author

I'd like to work on it, but I doubt that I will manage to find the time to.
However, if that miracle happen… It's good to know that contribution will be received with enthusiasm and not trashed away :-)

@Phyks
Copy link
Contributor

Phyks commented Jun 23, 2017

I can try to write something using Vue.JS, but don't want to promise anything till I am sure to have enough time to finish it.

@QuentinRoy
Copy link
Member

Actually we already started this project a few years ago (using React): https://github.com/almet/ireallyhatemoney. Unfortunately we never hard the time to continue.

@QuentinRoy
Copy link
Member

Also we had very little knowledge of React at that time. I just had new look at it, I'm not sure it's worse keeping.

@Phyks
Copy link
Contributor

Phyks commented Jun 23, 2017

Ok, I'll try to have a look. I can write something in React if you prefer, but would rather go for Vue. Anyways, if people working on this are more at ease with one or another, I can adapt :)

@QuentinRoy
Copy link
Member

I feel like both are similarly good. I tend to prefer React, mostly because I am not a big fan of Vue's templating syntax (I like the way it deals with scoped CSS though), but I don't have enough experience with Vue to make a judgement. Anyway, unfortunately, I do not expect to have the time to work on this anytime soon (even though I wish) so I don't feel my opinion should matter :).

@JocelynDelalande
Copy link
Contributor Author

My take on this : go ahead and write with your favorite framework. None of those tools are bad, I like to say that the one who actualy write something choose the tool :-)

Despite what I said, I am not sure of having the time to write something regarding this work. The first who moves notify the others :-)

@almet
Copy link
Member

almet commented Jun 23, 2017

I've exactly the same opinion as @JocelynDelalande. Let's just do it. This project started as an experimentation of a new technology (Flask was a few weeks old then), so let's keep it like that :-)

@almet almet changed the title Switch to AngularJS/ReactJS Make a full JavaScript client Jun 23, 2017
@Phyks
Copy link
Contributor

Phyks commented Jun 23, 2017

Ok, I'll let you know if I can get some time to start this :)

@0livd
Copy link
Member

0livd commented Jun 23, 2017

@Phyks That sounds cool ! I recently started to hack around with Vue.js so I can give a hand if needed

@almet
Copy link
Member

almet commented Nov 1, 2017

I would be interested if we can kick-off a project using vue.js, even if it's not usable, but just something to hack on. Don't hesitate to share inspirational projects / gists or anything that might help us getting started on this :)

@0livd
Copy link
Member

0livd commented Nov 5, 2017

I actually made this a couple of months ago and totally forgot about it :). https://gist.github.com/0livd/ecbfe221d8e57039ef10cd5afbdf8a2a
I think it is a good starting point to hack around and learn Vue.js but I guess we should ultimately use something like webpack. I don't think I'll have time to do more than this though.

@Phyks
Copy link
Contributor

Phyks commented Nov 5, 2017

I have a couple of Vue-based webapp around, which I can point you too if you want some reference. Unfortunately, I don't think I could commit into writing anything soon :/

@almet
Copy link
Member

almet commented Nov 6, 2017

Pointing to them is always useful. I probably won't commit time to this in the near future, but for whoever is interested, please share :)

@Phyks
Copy link
Contributor

Phyks commented Nov 6, 2017

Here is a webapp built around a basis similar to Ihatemoney (Vue.JS frontend with a python + bottle backend for the api). Server code is also in the same repo.

Here is a WIP using Vue.JS frontend (and Vuetify, an awesome framework to quickly set up a Material design webapp) wrapping around OpenFoodFacts API.

The latter is based upon Vue templates which are templates to kickstart a project, wrapping all the complicated webpack / testing stuff. In my opinion, that's pretty awesome and one of the most convenient way to start a Vue project quickly.

EDIT: Even if I can't commit on writing anything at the moment, please feel free to ping me here or on IRC if I can be useful for anything related to this issue (like tips or whatever) :)

@almet
Copy link
Member

almet commented Jan 24, 2019

For future reference, @Natim started working on exaclty this, powered by elm. It's at https://github.com/spiral-project/elm-ihatemoney

@almet
Copy link
Member

almet commented Oct 17, 2019

I'm closing this, I'm not sure we want this for IHM. Feel free to reopen if you think I'm mistaken, but the issue is two years old, we've got one implementation in elm and still use the good old HTML and Jinja.

@almet almet closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants