Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight is being rounded on balance member list #838

Closed
danielnetop opened this issue Sep 15, 2021 · 2 comments
Closed

Weight is being rounded on balance member list #838

danielnetop opened this issue Sep 15, 2021 · 2 comments

Comments

@danielnetop
Copy link
Contributor

Currently the user's weight are being rounded on to 1 decimal case only, so if we select 0.75 as the weight for one user and 0.25 for the other we see on the balance member list as 0.8 and 0.2 image below:
image

@Glandos
Copy link
Member

Glandos commented Sep 16, 2021

Thanks for this suggestion, I have to admit that I also like to have two decimals. Is it possible for you to add a new test case for this? I'll guess that we need to test that:

  • 1.0 is displayed as 1
  • 1.10 is displayed as 1.1
  • 1.15 is displayed as 1.15

@danielnetop
Copy link
Contributor Author

Thank you @Glandos
I've just updated the PR with the test cases.

TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this issue Mar 2, 2024
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants