Almet/qrcode #1000
Merged
Almet/qrcode #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Cool, I've included a link, it's now like this : |
|
I've reworded to "Scan QR code". Otherwise, it's OK for me! |
Merged
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Add a QRCode utility to join the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to display a QRCode when inviting other people. I'm not sure how this should be done specifically, but at least it works.
My main concerns is that not everybody is using Money Buster, nor knows what it is, so we might want to make it explicit that it's an Android app. The URL encoded in the QRCode has a
ihatemoney://scheme, so it might not work if MoneyBuster is not installed, and we don't want to lose people here.Let me know what you think :-)