Convert MAIL_DEFAULT_SENDER to a string #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorun
reviewed
Mar 20, 2022
|
Strange, the CI did not run... |
Github is having issues recently with this. |
almet
reviewed
Mar 24, 2022
ihatemoney/run.py
Outdated
| @@ -102,6 +102,15 @@ def validate_configuration(app): | |||
| if "MAIL_DEFAULT_SENDER" not in app.config: | |||
| app.config["MAIL_DEFAULT_SENDER"] = default_settings.DEFAULT_MAIL_SENDER | |||
|
|
|||
| if type(app.config["MAIL_DEFAULT_SENDER"]) == tuple: | |||
| warnings.warn( | |||
| "MAIL_DEFAULT_SENDER is not a tuple anymore and should be converted to a simple string." | |||
There was a problem hiding this comment.
We might want to provide the config line to change, since we have the tuple?
|
Looks good to me, we can probably make the life of the admins easier by letting them know what the new config line should look like in their case. |
|
What? Helping admin? This is a weird requirement! |
almet
reviewed
Mar 27, 2022
| warnings.warn( | ||
| "MAIL_DEFAULT_SENDER is not a tuple anymore and should be converted to a simple string." | ||
| "MAIL_DEFAULT_SENDER has been changed from tuple to string." | ||
| + f" It was converted to '{app.config['MAIL_DEFAULT_SENDER']}'." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1005