Add a Cancel Button when editing a bill #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
|
I have just seen that the pull request has not pass the tests that seem related to the database. However I have not touch it, maybe there is something I'm missing ? |
@almet do you have any idea ? I don't really see what's wrong |
|
Hey, it's not related to the work you've done, we have an issue currently on this project which makes the tests not pass. We're currently solving it in #1012. We will merge your changes just after :-) Thanks, anyways, it seems to be great :-) |
Glandos
requested changes
May 1, 2022
Co-authored-by: Glandos <bugs-github@antipoul.fr>
Glandos
approved these changes
May 8, 2022
|
Thanks! |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Co-authored-by: Glandos <bugs-github@antipoul.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #1001