Feature Request: Add a confirmation on expense deletion #1077 #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I feel we could refactor some code with the exact same thing happening with user deletion (just a few lines up in the JS). What do you think? |
|
Also, see #1099 |
|
I followed the JS convention that @Glandos pointed out in the original feature request (#1077). It is the same as the confirmation that is found in the project deletion workflow. I personally thought that the design looked better and drew better attention to the expense deletion than the user deletion confirmation. What are your thoughts? |
|
I thought originally that we could do some refactoring, but you're right : let's merge this :-) Thanks |
Glandos
added a commit
to Glandos/ihatemoney
that referenced
this pull request
Jan 28, 2023
Now the "danger" strings appears nearly everywhere, but the test looks for a flash message, thus "alert-danger"
Glandos
added a commit
that referenced
this pull request
Jan 28, 2023
Now the "danger" strings appears nearly everywhere, but the test looks for a flash message, thus "alert-danger"
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Now the "danger" strings appears nearly everywhere, but the test looks for a flash message, thus "alert-danger"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed feature request #1077 to use the double-click confirmation button that is also found in edit_project.html. This will prevent the accidental deletion of expenses (a destructive operation) with no warning.