[CI] Build mutli-architecture docker image #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Would be great to get this in! I'm also currently building my own images for ARM. |
|
Well, I'm not a Docker person, but this seems the right way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built an arm/v7 image locally with buildx and run it on my raspberry pi 3 successfully (https://hub.docker.com/r/greedybro/ihatemoney/tags)
Since the project CI is already using buildx via
docker/build-push-action@v2, it should only require to had a list of architectures to build for.The list should cover most of user needs with
armv7for rapsberry 3 and before, andarm64for Mac with Apple silicon and raspberry 4 (and probabilly future models)Closes #1066