Migrate existing sessions after conversion to dict #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Hey, thanks for the fix. This looks all good to me. Straightforward!
A few comments :
- Nitpick, really, but "we need to handle this" seems superfluous to me.
- With Migrate to pytest #1149 around the corner I want to use plain asserts, but I guess it's not merged yet!
Thanks again. I let you merge it, with or without changes.
|
Can we have minor release with this patch? |
|
@Glandos on my side, you can definitely merge this as-is, and then yes we can do a bugfix release. |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Migrate existing session after spiral-project#1082 fix spiral-project#1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1188