Add more details for bills in the history #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorun
changed the title
|
The principle and implementation looks good to me, thanks! Can you just change the strings to make translation easier:
|
Jojo144
force-pushed
the
history-more-details
branch
from
d826e22
to
2ee2e33
Compare
|
Done! |
|
Thanks! (Note: the test are failing, but this is unrelated, I fixed it in #1233 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add more details for bills in the history for each operation: insert, update, delete.
The idea is to be able to easily know what was a bill at some time (which can be difficult when it has been modified several times).
The PR also shorten long URL with an ellipsis
...to avoid big overflows.