Migrate from setup.cfg to pyproject.toml #1243
Conversation
| console_scripts = | ||
| ihatemoney = ihatemoney.manage:cli | ||
|
|
||
| paste.app_factory = |
There was a problem hiding this comment.
Is paste deployment still used? (I have not migrated this entry point as I am not sure how to migrate this to pyproject.toml)
There was a problem hiding this comment.
I've checked and it seems that all the documented deployment options and configuration files are relying on the wsgi module, so we probably don't need to maintain this.
| "Documentation" = "https://ihatemoney.readthedocs.io/en/latest/" | ||
|
|
||
| [project.scripts] | ||
| ihatemoney = "ihatemoney.manage:cli" |
There was a problem hiding this comment.
This makes the ihatemoney command available.
| @@ -32,14 +32,14 @@ def runserver(ctx): | |||
| ctx.forward(run) | |||
|
|
|||
|
|
|||
| @click.command(name="generate_password_hash") | |||
| @cli.command(name="generate_password_hash") | |||
There was a problem hiding this comment.
This was needed to provide ihatemoney generate_password_hash
| "Source Code" = "https://github.com/spiral-project/ihatemoney" | ||
| "Main instance" = "https://ihatemoney.org/" | ||
| "Mobile app" = "https://ihatemoney.org/mobile" | ||
| "Documentation" = "https://ihatemoney.readthedocs.io/en/latest/" |
There was a problem hiding this comment.
[project.urls] allows for more urls to be displayed on the PyPI page.
azmeuk
force-pushed
the
issue-1238-catalogs
branch
from
3bf9d33
to
ab73308
Compare
|
Thanks for the work @azmeuk @almet Could you please let time for other people to review changes before merging them extra-fast? In that case, I would have like to:
|
|
@zorun I'm sorry I didn't let you more time to review this. I understand what you mean and why it could have been simpler to merge it later on. I believe these scenarii will probably happen more often than before, as more people are working on the repository than usual. We might want to setup some rules for merging, releasing, etc. I see different ways to solve this, I've open #1245 to discuss that. |
I was having a look at #1238 and I realized that setuptools+setup.cfg is not really convenient for build callbacks (such as: catalog compilation).
I was thinking about using hatch instead of setuptools to build packages, like we did recently in wtforms, as it is lightweight and provides build callbacks, and setuptools is deprecated anyways (since it is built on distutils, that have just been deleted in python 3.12).
Anyways, if we use hatch in the future (or flit, or poetry, or whatever), then pyproject.toml is required, and if we keep using setuptools, pyproject.toml won't harm :)
We can have the discussion about the build tool on #1238