update to flask and werkzeug 2.3 #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum. Actually there are some CI tests failing... |
azmeuk
force-pushed
the
flask-2.3
branch
3 times, most recently
from
3da7e74
to
c8c345b
Compare
azmeuk
force-pushed
the
flask-2.3
branch
2 times, most recently
from
bb3047d
to
7928f8c
Compare
|
CI is fixed now. |
|
While reviewing recent changes to update the changelog, I'm confused about this change: it seems that it does not actually update the Flask dependency, it just updates a test. Is it expected? |
|
At first it was updating the dependencies too, I suppose the "merge master branch" modified that. |
|
Ah right, the merge is the obvious suspect. @almet can you look at what happened? |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Co-authored-by: Alexis Métaireau <alexis@notmyidea.org>
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
The update was previously made by @azmeuk but lost in a bad merge (see spiral-project#1244 for details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything looks fine, there was just a test to edit except for python 3.7