-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove strict_slashes for / #358
Conversation
I don't know why, but on my setup (nginx + uwsgi), the `strict_slashes` (default to `True`) was causing an infinite loop. I think it could be safely removed for this route only.
@Glandos out of curiosity, what was your nginx conf ? |
location / {
include uwsgi_params;
uwsgi_pass unix:/run/uwsgi/ihatemoney.socket;
}
location /static {
gzip_static on;
} The And in my uwsgi configuration: wsgi-file = /var/www/example.com/ihatemoney/ihatemoney/wsgi.py
callable = application
env = IHATEMONEY_SETTINGS_FILE_PATH=/var/www/example.com/ihatemoney/data/ihatemoney.cfg
venv = /var/www/example.com/ihatemoney/venv-system/ |
I've got the same problem simply running This PR fixed the problem. |
The fix seems okay. Can we add a small test case for it? Thanks! |
Here you are. The test is failing if |
fixed! |
I don't know why, but on my setup (nginx + uwsgi), the
strict_slashes
(default toTrue
) was causing an infinite loop.I think it could be safely removed for this route only.